5cd6461b6

Glenn L McGrath

2003-08-29

FAILED Duration: 91s

Subject

"Due to a wrong format parameter in a printf httpd does not work when compiled for with CONFIG_LFS (large file support). The attached patch suggested by Vladimir fixes that." - Steven Scholz

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

networking/httpd.c +8 -1

networking/httpd.c+8 -1

@@ -127,6 +127,13 @@ static const char default_path_httpd_conf[] = "/etc";
	static const char httpd_conf[] = "httpd.conf";
	static const char home[] = "./";

+	#ifdef CONFIG_LFS
+	# define cont_l_fmt "%lld"
+	#else
+	# define cont_l_fmt "%ld"
+	#endif
+
+
	// Note: bussybox xfuncs are not used because we want the server to keep running
	// if something bad happens due to a malformed user request.
	// As a result, all memory allocation after daemonize
@@ -932,7 +939,7 @@ static int sendHeaders(HttpResponseNum responseNum)
	#endif
	if (config->ContentLength != -1) { /* file */
	strftime(timeStr, sizeof(timeStr), RFC1123FMT, gmtime(&config->last_mod));
-	len += sprintf(buf+len, "Last-Modified: %s\r\n%s %ld\r\n",
+	len += sprintf(buf+len, "Last-Modified: %s\r\n%s " cont_l_fmt "\r\n",
	timeStr, Content_length, config->ContentLength);
	}
	strcat(buf, "\r\n");