← Commit list

5edc10275

Rob Landley
Rob Landley
2006-05-26
SOURCE BUG Duration: 50s

Subject

Slight sanity fix: data is void *, not char *. And it's called data almost everywhere, so be consistent.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

include/libbb.h+2 -2
@@ -84,8 +84,8 @@ typedef struct llist_s {
char *data;
struct llist_s *link;
} llist_t;
-extern llist_t *llist_add_to(llist_t *old_head, char *new_item);
-extern llist_t *llist_add_to_end(llist_t *list_head, char *data);
+extern llist_t *llist_add_to(llist_t *old_head, void *data);
+extern llist_t *llist_add_to_end(llist_t *list_head, void *data);
extern void *llist_pop(llist_t **elm);
extern void llist_free(llist_t *elm, void (*freeit)(void *data));
libbb/llist.c+3 -3
@@ -14,12 +14,12 @@
#ifdef L_llist_add_to
/* Add data to the start of the linked list. */
-llist_t *llist_add_to(llist_t *old_head, char *new_item)
+llist_t *llist_add_to(llist_t *old_head, void *data)
{
llist_t *new_head;
new_head = xmalloc(sizeof(llist_t));
- new_head->data = new_item;
+ new_head->data = data;
new_head->link = old_head;
return (new_head);
@@ -28,7 +28,7 @@ llist_t *llist_add_to(llist_t *old_head, char *new_item)
#ifdef L_llist_add_to_end
/* Add data to the end of the linked list. */
-llist_t *llist_add_to_end(llist_t *list_head, char *data)
+llist_t *llist_add_to_end(llist_t *list_head, void *data)
{
llist_t *new_item;