615362909

Bernhard Reutner-Fischer

2006-04-03

SOURCE BUG Duration: 9s

Subject

- set flags in a more reasonable manner. Thanks, vodz. text data bss dec hex filename 3520 4 96 3620 e24 networking/arping.o.oorig 3488 4 96 3588 e04 networking/arping.o

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

networking/arping.c +5 -16

networking/arping.c+5 -16

@@ -36,8 +36,8 @@ enum cfg_e {
	advert = 4,
	quiet = 8,
	quit_on_reply = 16,
-	unicasting = 32,
-	broadcast_only = 64
+	broadcast_only = 32,
+	unicasting = 64
	};
	static int cfg;

@@ -281,22 +281,11 @@ int arping_main(int argc, char **argv)
	char _count, _timeout, *_device;
	opt = bb_getopt_ulflags(argc, argv, "DUAqfbc:w:i:s:",
	&_count, &_timeout, &_device);
-	if (opt & 1) { /* Dad */
-	cfg \|= dad;
+	cfg \|= opt & 63; /* set respective flags */
+	if (opt & 1) /* Dad also sets quit_on_reply */
	cfg \|= quit_on_reply;
-	}
-	if (opt & 2) /* Unsolicited */
-	cfg \|= unsolicited;
-	if (opt & 4) { /* Advert */
-	cfg \|= advert;
+	if (opt & 4) /* Advert also sets unsolicited */
	cfg \|= unsolicited;
-	}
-	if (opt & 8) /* quiet */
-	cfg \|= quiet;
-	if (opt & 16) /* quit on reply */
-	cfg \|= quit_on_reply;
-	if (opt & 32) /* broadcast only */
-	cfg \|= broadcast_only;
	if (opt & 64) /* count */
	count = atoi(_count);
	if (opt & 128) /* timeout */