6417564ee

Rob Landley

2005-08-22

SOURCE BUG Duration: 5s

Subject

Two FEATURE_CLEAN_UP patches from Shaun Jackman, closing filehandles.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

libbb/xconnect.c +1 -0 networking/route.c +2 -4

libbb/xconnect.c+1 -0

@@ -64,6 +64,7 @@ int xconnect(struct sockaddr_in *s_addr)
	int s = socket(AF_INET, SOCK_STREAM, 0);
	if (connect(s, (struct sockaddr_in *)s_addr, sizeof(struct sockaddr_in)) < 0)
	{
+	if (ENABLE_FEATURE_CLEAN_UP) close(s);
	bb_perror_msg_and_die("Unable to connect to remote host (%s)",
	inet_ntoa(s_addr->sin_addr));
	}

networking/route.c+2 -4

@@ -329,8 +329,7 @@ static void INET_setroute(int action, char **args)
	bb_perror_msg_and_die("SIOC[ADD\|DEL]RT");
	}

-	/* Don't bother closing, as we're exiting after we return anyway. */
-	/* close(skfd); */
+	if (ENABLE_FEATURE_CLEAN_UP) close(skfd);
	}

	#ifdef CONFIG_FEATURE_IPV6
@@ -440,8 +439,7 @@ static void INET6_setroute(int action, char **args)
	bb_perror_msg_and_die("SIOC[ADD\|DEL]RT");
	}

-	/* Don't bother closing, as we're exiting after we return anyway. */
-	/* close(skfd); */
+	if (ENABLE_FEATURE_CLEAN_UP) close(skfd);
	}
	#endif