← Commit list

67075bb95

Denis Vlasenko
Denis Vlasenko
2008-07-06
FAILED Duration: 22s

Subject

mdev: reinstate "follow symlinks" flag, this time with explanation

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

util-linux/mdev.c+7 -4
@@ -420,14 +420,17 @@ int mdev_main(int argc, char **argv)
root_major = major(st.st_dev);
root_minor = minor(st.st_dev);
+ /* ACTION_FOLLOWLINKS is needed since in newer kernels
+ * /sys/block/loop* (for example) are symlinks to dirs,
+ * not real directories.
+ * (kernel's CONFIG_SYSFS_DEPRECATED makes them real dirs,
+ * but we can't enforce that on users) */
recursive_action("/sys/block",
- ACTION_RECURSE /* no ACTION_FOLLOWLINKS! */,
+ ACTION_RECURSE | ACTION_FOLLOWLINKS,
fileAction, dirAction, temp, 0);
-
recursive_action("/sys/class",
- ACTION_RECURSE /* no ACTION_FOLLOWLINKS! */,
+ ACTION_RECURSE | ACTION_FOLLOWLINKS,
fileAction, dirAction, temp, 0);
-
} else {
/* Hotplug:
* env ACTION=... DEVPATH=... mdev