6b00d0d3c — BusyBox

Subject

Put the menu_is_visible test back because it avoids printing spurious (albeit commented out) garbage.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

scripts/config/confdata.c +12 -12

scripts/config/confdata.c+12 -12

@@ -322,18 +322,18 @@ int conf_write(const char *name)
	while (menu) {
	sym = menu->sym;
	if (!sym) {
-	//if (!menu_is_visible(menu))
-	// goto next;
-	str = menu_get_prompt(menu);
-	fprintf(out, "\n"
-	"#\n"
-	"# %s\n"
-	"#\n", str);
-	if (out_h)
-	fprintf(out_h, "\n"
-	"/*\n"
-	" * %s\n"
-	" */\n", str);
+	if (menu_is_visible(menu)) {
+	str = menu_get_prompt(menu);
+	fprintf(out, "\n"
+	"#\n"
+	"# %s\n"
+	"#\n", str);
+	if (out_h)
+	fprintf(out_h, "\n"
+	"/*\n"
+	" * %s\n"
+	" */\n", str);
+	}
	} else if (!(sym->flags & SYMBOL_CHOICE)) {
	sym_calc_value(sym);
	//if (!(sym->flags & SYMBOL_WRITE))