6cd225095

Rob Landley

2006-05-25

SOURCE BUG Duration: 61s

Subject

Remove a pointless #define.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

networking/nc.c +5 -4

networking/nc.c+5 -4

@@ -37,8 +37,6 @@ int nc_main(int argc, char **argv)
	{
	int do_listen = 0, lport = 0, delay = 0, wsecs = 0, tmpfd, opt, sfd, x;

-	#define buf bb_common_bufsiz1
-
	#ifdef CONFIG_NC_GAPING_SECURITY_HOLE
	char *pr00gie = NULL;
	#endif
@@ -146,8 +144,11 @@ int nc_main(int argc, char **argv)

	for (fd = 0; fd < FD_SETSIZE; fd++) {
	if (FD_ISSET(fd, &testfds)) {
-	if ((nread = safe_read(fd, buf, sizeof(buf))) < 0)
+	if ((nread = safe_read(fd, bb_common_bufsiz1,
+	sizeof(bb_common_bufsiz1))) < 0)
+	{
	bb_perror_msg_and_die(bb_msg_read_error);
+	}

	if (fd == sfd) {
	if (nread == 0)
@@ -162,7 +163,7 @@ int nc_main(int argc, char **argv)
	ofd = sfd;
	}

-	if (bb_full_write(ofd, buf, nread) < 0)
+	if (bb_full_write(ofd, bb_common_bufsiz1, nread) < 0)
	bb_perror_msg_and_die(bb_msg_write_error);
	if (delay > 0) {
	sleep(delay);