← Commit list

6d0443557

Denis Vlasenko
Denis Vlasenko
2008-11-09
FAILED Duration: 31s

Subject

telnetd: set SO_KEEPALIVE, users report it's useful. +20 bytes.

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

networking/telnetd.c+4 -0
@@ -182,6 +182,8 @@ make_new_session(
ndelay_on(fd);
#if ENABLE_FEATURE_TELNETD_STANDALONE
ts->sockfd_read = sock;
+ /* SO_KEEPALIVE by popular demand */
+ setsockopt(sock, SOL_SOCKET, SO_KEEPALIVE, &const_int_1, sizeof(const_int_1));
ndelay_on(sock);
if (!sock) { /* We are called with fd 0 - we are in inetd mode */
sock++; /* so use fd 1 for output */
@@ -191,6 +193,8 @@ make_new_session(
if (sock > maxfd)
maxfd = sock;
#else
+ /* SO_KEEPALIVE by popular demand */
+ setsockopt(0, SOL_SOCKET, SO_KEEPALIVE, &const_int_1, sizeof(const_int_1));
/* ts->sockfd_read = 0; - done by xzalloc */
ts->sockfd_write = 1;
ndelay_on(0);