6ebbc7414

Mike Frysinger

2005-08-16

SOURCE BUG Duration: 6s

Subject

the () around isspace actually matters

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

libbb/xgetlarg.c +4 -2

libbb/xgetlarg.c+4 -2

@@ -21,8 +21,10 @@ extern long bb_xgetlarg(const char *arg, int base, long lower, long upper)

	assert(arg!=NULL);

-	/* Don't allow leading whitespace. */
-	if (isspace(arg)) { / Use an actual function call for minimal size. */
+	/* Don't allow leading whitespace.
+	* Wrap isspace in () to make sure we call the
+	* function rather than the macro. */
+	if ((isspace)(*arg)) {
	bb_show_usage();
	}