← Commit list

7310339e7

Alyssa Ross via busybox
Alyssa Ross via busybox
2026-02-04
SUCCESS Duration: 162s

Subject

volume_id: volume_id_get_buffer with small FSes

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0
gcc -Wp,-MD,applets/.usage.d -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer      -Iinclude -Iinclude -o applets/usage applets/usage.c

Build Log

(log yok)

Commit Diff GitHub →

util-linux/volume_id/util.c+2 -3
@@ -233,11 +233,10 @@ void *volume_id_get_buffer(struct volume_id *id, uint64_t off, size_t len)
err:
/* No filesystem can be this tiny. It's most likely
* non-associated loop device, empty drive and so on.
- * Flag it, making it possible to short circuit future
- * accesses. Rationale:
+ * Flag it, avoiding future accesses. Rationale:
* users complained of slow blkid due to empty floppy drives.
*/
- if (off < 64*1024)
+ if (off <= 1024)
id->error = 1;
/* id->seekbuf_len or id->sbbuf_len is wrong now! Fixing. */
volume_id_free_buffer(id);