73804d6f7

"Vladimir N. Oleynik"

2006-02-28

SOURCE BUG Duration: 33s

Subject

more security: don't start shell code from argv

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

miscutils/eject.c +1 -1 util-linux/setarch.c +1 -1

miscutils/eject.c+1 -1

@@ -43,7 +43,7 @@ extern int eject_main(int argc, char **argv)
	}
	if (ioctl(bb_xopen(device, (O_RDONLY \| O_NONBLOCK)),
	(flags ? CDROMCLOSETRAY : CDROMEJECT))) {
-	bb_perror_msg_and_die(device);
+	bb_perror_msg_and_die("%s", device);
	}
	return (EXIT_SUCCESS);
	}

util-linux/setarch.c+1 -1

@@ -49,5 +49,5 @@ retry:
	execvp(argv[0], argv);

	failure:
-	bb_perror_msg_and_die(argv[0]);
+	bb_perror_msg_and_die("%s", argv[0]);
	}