752f0a600

Rob Landley

2006-05-30

SOURCE BUG Duration: 32s

Subject

Put parentheses around some of the SWAP() macros, as pointed out by Peter Kjellerstedt.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

include/platform.h +6 -6

include/platform.h+6 -6

@@ -114,9 +114,9 @@
	#endif

	#if BB_BIG_ENDIAN
-	#define SWAP_BE16(x) x
-	#define SWAP_BE32(x) x
-	#define SWAP_BE64(x) x
+	#define SWAP_BE16(x) (x)
+	#define SWAP_BE32(x) (x)
+	#define SWAP_BE64(x) (x)
	#define SWAP_LE16(x) bswap_16(x)
	#define SWAP_LE32(x) bswap_32(x)
	#define SWAP_LE64(x) bswap_64(x)
@@ -124,9 +124,9 @@
	#define SWAP_BE16(x) bswap_16(x)
	#define SWAP_BE32(x) bswap_32(x)
	#define SWAP_BE64(x) bswap_64(x)
-	#define SWAP_LE16(x) x
-	#define SWAP_LE32(x) x
-	#define SWAP_LE64(x) x
+	#define SWAP_LE16(x) (x)
+	#define SWAP_LE32(x) (x)
+	#define SWAP_LE64(x) (x)
	#endif

	/* ---- Networking ------------------------------------------ */