← Commit list

75c6b7962

Mike Frysinger
Mike Frysinger
2006-06-06
SOURCE BUG Duration: 42s

Subject

fix from uClinux-dist for proper exit status if reading /proc/modules failed

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

modutils/lsmod.c+5 -5
@@ -190,13 +190,13 @@ int lsmod_main(int argc, char **argv)
}
fclose(file);
}
- return 0; /* Success */
+ return EXIT_SUCCESS;
#else
- if (bb_xprint_file_by_name("/proc/modules") < 0) {
- return 0;
- }
+ if (bb_xprint_file_by_name("/proc/modules") == 0)
+ return EXIT_SUCCESS;
#endif /* CONFIG_FEATURE_2_6_MODULES */
- return 1;
+
+ return EXIT_FAILURE;
}
#endif /* CONFIG_FEATURE_QUERY_MODULE_INTERFACE */