7750b5a25
Denys Vlasenko
2022-03-01
Subject
ash: fix unsafe use of mempcpy
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
shell/ash.c+7 -1
| @@ -7191,7 +7191,13 @@ subevalvar(char *start, char *str, int strloc, | |
| len = orig_len - pos; | |
| if (!quotes) { | |
| - | loc = mempcpy(startp, startp + pos, len); |
| + | /* want: loc = mempcpy(startp, startp + pos, len) |
| + | * but it does not allow overlapping arguments */ |
| + | loc = startp; |
| + | while (--len >= 0) { |
| + | *loc = loc[pos]; |
| + | loc++; |
| + | } |
| } else { | |
| for (vstr = startp; pos != 0; pos--) { | |
| if ((unsigned char)*vstr == CTLESC) | |