77d487269
Dan Fandrich
2010-09-09
Subject
Avoid side effects in putc(), which may be implemented as a macro
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
coreutils/ls.c+2 -1
| @@ -573,7 +573,8 @@ static unsigned print_name(const char *name) | |
| putchar('\\'); | |
| len++; | |
| } | |
| - | putchar(*name++); |
| + | putchar(*name); |
| + | name++; |
| } | |
| putchar('"'); | |
| return len; | |
coreutils/tee.c+4 -4
| @@ -70,8 +70,8 @@ int tee_main(int argc, char **argv) | |
| while ((c = safe_read(STDIN_FILENO, buf, sizeof(buf))) > 0) { | |
| fp = files; | |
| do | |
| - | fwrite(buf, 1, c, *fp++); |
| - | while (*fp); |
| + | fwrite(buf, 1, c, *fp); |
| + | while (*++fp); |
| } | |
| if (c < 0) { /* Make sure read errors are signaled. */ | |
| retval = EXIT_FAILURE; | |
| @@ -81,8 +81,8 @@ int tee_main(int argc, char **argv) | |
| while ((c = getchar()) != EOF) { | |
| fp = files; | |
| do | |
| - | putc(c, *fp++); |
| - | while (*fp); |
| + | putc(c, *fp); |
| + | while (*++fp); |
| } | |
| #endif | |
shell/ash.c+6 -3
| @@ -953,7 +953,8 @@ sharg(union node *arg, FILE *fp) | |
| for (p = arg->narg.text; *p; p++) { | |
| switch ((unsigned char)*p) { | |
| case CTLESC: | |
| - | putc(*++p, fp); |
| + | p++; |
| + | putc(*p, fp); |
| break; | |
| case CTLVAR: | |
| putc('$', fp); | |
| @@ -962,8 +963,10 @@ sharg(union node *arg, FILE *fp) | |
| if (subtype == VSLENGTH) | |
| putc('#', fp); | |
| - | while (*p != '=') |
| - | putc(*p++, fp); |
| + | while (*p != '=') { |
| + | putc(*p, fp); |
| + | p++; |
| + | } |
| if (subtype & VSNUL) | |
| putc(':', fp); | |