← Commit list

78b286fea

Alexander Shishkin
Alexander Shishkin
2010-10-28
FAILED Duration: 277s

Subject

login: free fromhost upon cleaning up

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

loginutils/login.c+7 -0
@@ -364,6 +364,10 @@ int login_main(int argc UNUSED_PARAM, char **argv)
if (++count == 3) {
syslog(LOG_WARNING, "invalid password for '%s'%s",
username, fromhost);
+
+ if (ENABLE_FEATURE_CLEAN_UP)
+ free(fromhost);
+
return EXIT_FAILURE;
}
username[0] = '\0';
@@ -401,6 +405,9 @@ int login_main(int argc UNUSED_PARAM, char **argv)
if (pw->pw_uid == 0)
syslog(LOG_INFO, "root login%s", fromhost);
+ if (ENABLE_FEATURE_CLEAN_UP)
+ free(fromhost);
+
/* well, a simple setexeccon() here would do the job as well,
* but let's play the game for now */
IF_SELINUX(set_current_security_context(user_sid);)