78bd50494

Mike Frysinger

2006-04-16

SOURCE BUG Duration: 40s

Subject

use memcmp() not bcmp()

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

libbb/dump.c +2 -2

libbb/dump.c+2 -2

@@ -380,7 +380,7 @@ static unsigned char *get(void)
	if (need == bb_dump_blocksize) {
	return ((unsigned char *) NULL);
	}
-	if (bb_dump_vflag != ALL && !bcmp(curp, savp, nread)) {
+	if (bb_dump_vflag != ALL && !memcmp(curp, savp, nread)) {
	if (bb_dump_vflag != DUP) {
	printf("*\n");
	}
@@ -405,7 +405,7 @@ static unsigned char *get(void)
	}
	if (!(need -= n)) {
	if (bb_dump_vflag == ALL \|\| bb_dump_vflag == FIRST
-	\|\| bcmp(curp, savp, bb_dump_blocksize)) {
+	\|\| memcmp(curp, savp, bb_dump_blocksize)) {
	if (bb_dump_vflag == DUP \|\| bb_dump_vflag == FIRST) {
	bb_dump_vflag = WAIT;
	}