← Commit list

7ababc3e3

Denys Vlasenko
Denys Vlasenko
2023-04-03
SUCCESS Duration: 157s

Subject

ash: fix still-broken new mail detection

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

shell/ash.c+4 -4
@@ -11265,8 +11265,8 @@ static smallint mail_var_path_changed;
/*
* Print appropriate message(s) if mail has arrived.
* If mail_var_path_changed is set,
- * then the value of MAIL has mail_var_path_changed,
- * so we just update the values.
+ * then the value of MAIL has changed,
+ * so we just update the hash value.
*/
static void
chkmail(void)
@@ -11285,7 +11285,7 @@ chkmail(void)
int len;
len = padvance_magic(&mpath, nullstr, 2);
- if (!len)
+ if (len < 0)
break;
p = stackblock();
if (*p == '\0')
@@ -11306,8 +11306,8 @@ chkmail(void)
if (!mail_var_path_changed && mailtime_hash != new_hash) {
if (mailtime_hash != 0)
out2str("you have mail\n");
- mailtime_hash = new_hash;
}
+ mailtime_hash = new_hash;
mail_var_path_changed = 0;
popstackmark(&smark);
}