7ae155398

Bernhard Reutner-Fischer

2006-05-30

SOURCE BUG Duration: 45s

Subject

- consolidate "Sending SIG%s to all processes"; untested.. text data bss dec hex filename 5379 32 8 5419 152b init/init.o.oorig 5358 32 8 5398 1516 init/init.o

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

init/init.c +2 -2 init/init_shared.c +4 -4 init/init_shared.h +1 -0

init/init.c+2 -2

@@ -683,12 +683,12 @@ static void shutdown_system(void)
	sync();

	/* Send signals to every process _except_ pid 1 */
-	message(CONSOLE \| LOG, "Sending SIGTERM to all processes.");
+	message(CONSOLE \| LOG, init_sending_format, "TERM");
	kill(-1, SIGTERM);
	sleep(1);
	sync();

-	message(CONSOLE \| LOG, "Sending SIGKILL to all processes.");
+	message(CONSOLE \| LOG, init_sending_format, "KILL");
	kill(-1, SIGKILL);
	sleep(1);

init/init_shared.c+4 -4

@@ -44,16 +44,16 @@ int bb_shutdown_system(unsigned long magic)
	sync();

	/* Send signals to every process _except_ pid 1 */
-	message = "Sending SIGTERM to all processes.";
-	syslog(pri, "%s", message);
+	message = "TERM";
+	syslog(pri, init_sending_format, message);
	printf(bb_shutdown_format, message);

	kill(-1, SIGTERM);
	sleep(1);
	sync();

-	message = "Sending SIGKILL to all processes.";
-	syslog(pri, "%s", message);
+	message = "KILL";
+	syslog(pri, init_sending_format, message);
	printf(bb_shutdown_format, message);

	kill(-1, SIGKILL);

init/init_shared.h+1 -0

@@ -1,3 +1,4 @@
	extern int kill_init(int sig);
	extern int bb_shutdown_system(unsigned long magic);
+	const char * const init_sending_format = "Sending SIG%s to all processes.";