← Commit list

7b4cd6f7b

Denys Vlasenko
Denys Vlasenko
2009-10-23
FAILED Duration: 27s

Subject

libbb: smaller isdigit. -95 bytes

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

include/libbb.h+3 -2
@@ -1579,9 +1579,10 @@ extern const char bb_default_login_shell[];
#undef isupper
#undef isxdigit
-/* This one is more efficient - we save ~400 bytes */
+/* This one is more efficient - we save ~500 bytes.
+ * BTW, x86 likes (unsigned char) cast more than (unsigned). */
#undef isdigit
-#define isdigit(a) ((unsigned)((a) - '0') <= 9)
+#define isdigit(a) ((unsigned char)((a) - '0') <= 9)
/* This one is more efficient too! ~200 bytes */
/* In POSIX/C locale (the only locale we care about: do we REALLY want