7b7c99ca3
Rob Landley
2005-11-04
Subject
Size I zapped the bb_close() error, might as well make a TODO item.
SOURCE BUG
This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
TODO+13 -1
| @@ -34,10 +34,22 @@ man | |
| --- | |
| bzip2 | |
| Compression-side support. | |
| - | |
| + | --- |
| + | init |
| + | General cleanup. |
| Architectural issues: | |
| + | bb_close() with fsync() |
| + | We should have a bb_close() in place of normal close, with a CONFIG_ option |
| + | to not just check the return value of close() for an error, but fsync(). |
| + | Close can't reliably report anything useful because if write() accepted the |
| + | data then it either went out or it's in cache or a pipe buffer. Either way, |
| + | there's no guarantee it'll make it to its final destination before close() |
| + | gets called, so there's no guarantee that any error will be reported. |
| + | You need to call fsync() if you care about errors that occur after write(), |
| + | but that can have a big performance impact. So make it a config option. |
| + | --- |
| Do a SUSv3 audit | |
| Look at the full Single Unix Specification version 3 (available online at | |
| "http://www.opengroup.org/onlinepubs/009695399/nfindex.html") and | |