7bb346f23
Denys Vlasenko
2009-10-06
Subject
*: use {i,u}toa() where appropriate
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
coreutils/cal.c +1 -1editors/awk.c +1 -3miscutils/fbsplash.c +1 -3runit/runsv.c +2 -4shell/ash.c +1 -3
coreutils/cal.c+1 -1
| @@ -147,7 +147,7 @@ int cal_main(int argc, char **argv) | |
| unsigned *dp; | |
| char lineout[80]; | |
| - | sprintf(lineout, "%d", year); |
| + | sprintf(lineout, "%u", year); |
| center(lineout, | |
| (WEEK_LEN * 3 + HEAD_SEP * 2) | |
| + julian * (J_WEEK_LEN * 2 + HEAD_SEP | |
editors/awk.c+1 -3
| @@ -765,11 +765,9 @@ static var *setvar_u(var *v, const char *value) | |
| /* set array element to user string */ | |
| static void setari_u(var *a, int idx, const char *s) | |
| { | |
| - | char sidx[sizeof(int)*3 + 1]; |
| var *v; | |
| - | sprintf(sidx, "%d", idx); |
| - | v = findvar(iamarray(a), sidx); |
| + | v = findvar(iamarray(a), itoa(idx)); |
| setvar_u(v, s); | |
| } | |
miscutils/fbsplash.c+1 -3
| @@ -391,9 +391,7 @@ int fbsplash_main(int argc UNUSED_PARAM, char **argv) | |
| num = atoi(num_buf); | |
| if (isdigit(num_buf[0]) && (num <= 100)) { | |
| #if DEBUG | |
| - | char strVal[10]; |
| - | sprintf(strVal, "%d", num); |
| - | DEBUG_MESSAGE(strVal); |
| + | DEBUG_MESSAGE(itoa(num)); |
| #endif | |
| fb_drawprogressbar(num); | |
| } | |
runit/runsv.c+2 -4
| @@ -311,7 +311,6 @@ static void startservice(struct svdir *s) | |
| int p; | |
| const char *arg[4]; | |
| char exitcode[sizeof(int)*3 + 2]; | |
| - | char sigcode[sizeof(int)*3 + 2]; |
| if (s->state == S_FINISH) { | |
| /* Two arguments are given to ./finish. The first one is ./run exit code, | |
| @@ -324,13 +323,12 @@ static void startservice(struct svdir *s) | |
| arg[0] = "./finish"; | |
| arg[1] = "-1"; | |
| if (WIFEXITED(s->wstat)) { | |
| - | sprintf(exitcode, "%u", (int) WEXITSTATUS(s->wstat)); |
| + | *utoa_to_buf(WEXITSTATUS(s->wstat), exitcode, sizeof(exitcode)) = '\0'; |
| arg[1] = exitcode; | |
| } | |
| //arg[2] = "0"; | |
| //if (WIFSIGNALED(s->wstat)) { | |
| - | sprintf(sigcode, "%u", (int) WTERMSIG(s->wstat)); |
| - | arg[2] = sigcode; |
| + | arg[2] = utoa(WTERMSIG(s->wstat)); |
| //} | |
| arg[3] = NULL; | |
| } else { | |
shell/ash.c+1 -3
| @@ -13083,7 +13083,6 @@ init(void) | |
| /* from var.c: */ | |
| { | |
| char **envp; | |
| - | char ppid[sizeof(int)*3 + 2]; |
| const char *p; | |
| struct stat st1, st2; | |
| @@ -13094,8 +13093,7 @@ init(void) | |
| } | |
| } | |
| - | sprintf(ppid, "%u", (unsigned) getppid()); |
| - | setvar("PPID", ppid, 0); |
| + | setvar("PPID", utoa(getppid()), 0); |
| p = lookupvar("PWD"); | |
| if (p) | |