← Commit list

7c2a3bdde

Sören Tempel
Sören Tempel
2022-08-02
SUCCESS Duration: 156s

Subject

ash: fix use-after-free in bash pattern substitution

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

shell/ash.c+7 -0
@@ -7357,6 +7357,13 @@ subevalvar(char *start, char *str, int strloc,
idx = loc;
}
+ /* The STPUTC invocations above may resize and move the
+ * stack via realloc(3). Since repl is a pointer into the
+ * stack, we need to reconstruct it relative to stackblock().
+ */
+ if (slash_pos >= 0)
+ repl = (char *)stackblock() + strloc + slash_pos + 1;
+
//bb_error_msg("repl:'%s'", repl);
for (loc = (char*)repl; *loc; loc++) {
char *restart_detect = stackblock();