← Commit list

7ccb65f3a

"Robert P. J. Day"
"Robert P. J. Day"
2006-07-01
SOURCE BUG Duration: 30s

Subject

Yet more "#if 0" content removed.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

e2fsprogs/blkid/read.c +0 -25e2fsprogs/ext2fs/closefs.c +0 -4e2fsprogs/ext2fs/icount.c +0 -14e2fsprogs/ext2fs/inode.c +0 -21e2fsprogs/fsck.c +0 -9e2fsprogs/mke2fs.c +0 -3e2fsprogs/util.c +0 -7scripts/objsizes +1 -2
e2fsprogs/blkid/read.c+0 -25
@@ -98,31 +98,6 @@ static char *strip_line(char *line)
return line;
}
-#if 0
-static char *parse_word(char **buf)
-{
- char *word, *next;
-
- word = *buf;
- if (*word == '\0')
- return NULL;
-
- word = skip_over_blank(word);
- next = skip_over_word(word);
- if (*next) {
- char *end = next - 1;
- if (*end == '"' || *end == '\'')
- *end = '\0';
- *next++ = '\0';
- }
- *buf = next;
-
- if (*word == '"' || *word == '\'')
- word++;
- return word;
-}
-#endif
-
/*
* Start parsing a new line from the cache.
*
e2fsprogs/ext2fs/closefs.c+0 -4
@@ -151,10 +151,6 @@ static errcode_t write_primary_superblock(ext2_filsys fs,
if (old_super[check_idx] == new_super[check_idx])
break;
size = 2 * (check_idx - write_idx);
-#if 0
- printf("Writing %d bytes starting at %d\n",
- size, write_idx*2);
-#endif
retval = io_channel_write_byte(fs->io,
SUPERBLOCK_OFFSET + (2 * write_idx), size,
new_super + write_idx);
e2fsprogs/ext2fs/icount.c+0 -14
@@ -112,10 +112,6 @@ errcode_t ext2fs_create_icount2(ext2_filsys fs, int flags, unsigned int size,
}
bytes = (size_t) (icount->size * sizeof(struct ext2_icount_el));
-#if 0
- printf("Icount allocated %d entries, %d bytes.\n",
- icount->size, bytes);
-#endif
retval = ext2fs_get_mem(bytes, &icount->list);
if (retval)
goto errout;
@@ -172,9 +168,6 @@ static struct ext2_icount_el *insert_icount_el(ext2_icount_t icount,
}
if (new_size < (icount->size + 100))
new_size = icount->size + 100;
-#if 0
- printf("Reallocating icount %d entries...\n", new_size);
-#endif
retval = ext2fs_resize_mem((size_t) icount->size *
sizeof(struct ext2_icount_el),
(size_t) new_size *
@@ -224,15 +217,9 @@ static struct ext2_icount_el *get_icount_el(ext2_icount_t icount,
icount->cursor = 0;
if (ino == icount->list[icount->cursor].ino)
return &icount->list[icount->cursor++];
-#if 0
- printf("Non-cursor get_icount_el: %u\n", ino);
-#endif
low = 0;
high = (int) icount->count-1;
while (low <= high) {
-#if 0
- mid = (low+high)/2;
-#else
if (low == high)
mid = low;
else {
@@ -249,7 +236,6 @@ static struct ext2_icount_el *get_icount_el(ext2_icount_t icount,
(highval - lowval);
mid = low + ((int) (range * (high-low)));
}
-#endif
if (ino == icount->list[mid].ino) {
icount->cursor = mid+1;
return &icount->list[mid];
e2fsprogs/ext2fs/inode.c+0 -21
@@ -355,27 +355,6 @@ static errcode_t get_next_blocks(ext2_inode_scan scan)
return 0;
}
-#if 0
-/*
- * Returns 1 if the entire inode_buffer has a non-zero size and
- * contains all zeros. (Not just deleted inodes, since that means
- * that part of the inode table was used at one point; we want all
- * zeros, which means that the inode table is pristine.)
- */
-static inline int is_empty_scan(ext2_inode_scan scan)
-{
- int i;
-
- if (scan->bytes_left == 0)
- return 0;
-
- for (i=0; i < scan->bytes_left; i++)
- if (scan->ptr[i])
- return 0;
- return 1;
-}
-#endif
-
errcode_t ext2fs_get_next_inode_full(ext2_inode_scan scan, ext2_ino_t *ino,
struct ext2_inode *inode, int bufsize)
{
e2fsprogs/fsck.c+0 -9
@@ -135,12 +135,6 @@ static char *base_device(const char *device)
goto errout;
cp += 5;
-#if 0 /* this is for old stuff no one uses anymore ? */
- /* Skip over /dev/dsk/... */
- if (strncmp(cp, "dsk/", 4) == 0)
- cp += 4;
-#endif
-
/*
* For md devices, we treat them all as if they were all
* on one disk, since we don't know how to parallelize them.
@@ -918,9 +912,6 @@ static void compile_fs_type(char *fs_type, struct fs_type_compile *cmp)
bb_error_msg_and_die("%s", fs_type_syntax_error);
}
}
-#if 0
- printf("Adding %s to list (type %d).\n", s, cmp->type[num]);
-#endif
cmp->list[num++] = string_copy(s);
s = strtok(NULL, ",");
}
e2fsprogs/mke2fs.c+0 -3
@@ -828,9 +828,6 @@ static int PRS(int argc, char *argv[])
param.s_rev_level = 1; /* Create revision 1 filesystems now */
param.s_feature_incompat |= EXT2_FEATURE_INCOMPAT_FILETYPE;
param.s_feature_ro_compat |= EXT2_FEATURE_RO_COMPAT_SPARSE_SUPER;
-#if 0
- param.s_feature_compat |= EXT2_FEATURE_COMPAT_DIR_INDEX;
-#endif
#ifdef __linux__
linux_version_code = get_linux_version_code();
e2fsprogs/util.c+0 -7
@@ -110,14 +110,7 @@ void parse_journal_opts(char **journal_device, int *journal_flags,
{
char *buf, *token, *next, *p, *arg;
int journal_usage = 0;
-#if 0
- int len;
- len = strlen(opts);
- buf = xmalloc(len+1);
- strcpy(buf, opts);
-#else
buf = bb_xstrdup(opts);
-#endif
for (token = buf; token && *token; token = next) {
p = strchr(token, ',');
next = 0;
scripts/objsizes+1 -2
@@ -4,5 +4,4 @@ printf "%9s %11s %9s %9s %s\n" "text+data" text+rodata rwdata bss filename
find -name '*.o' | sed 's:^\./::' | xargs size | grep '^ *[0-9]' \
| while read text data bss dec hex filename; do
printf "%9d %11d %9d %9d %s\n" $((text+data)) $text $data $bss "$filename"
-done \
-| sort
+done