← Commit list

802a7be54

Denis Vlasenko
Denis Vlasenko
2008-10-19
FAILED Duration: 31s

Subject

add comment explaining previous change

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

util-linux/volume_id/get_devname.c+11 -0
@@ -107,6 +107,17 @@ uuidcache_init(void)
if (uuidCache)
return;
+ /* We were scanning /proc/partitions
+ * and /proc/sys/dev/cdrom/info here.
+ * Missed volume managers. I see that "standard" blkid uses these:
+ * /dev/mapper/control
+ * /proc/devices
+ * /proc/evms/volumes
+ * /proc/lvm/VGs
+ * This is unacceptably complex. Let's just scan /dev.
+ * (Maybe add scanning of /sys/block/XXX/dev for devices
+ * somehow not having their /dev/XXX entries created?) */
+
recursive_action("/dev", ACTION_RECURSE,
uuidcache_check_device, /* file_action */
NULL, /* dir_action */