80f647c21
Denis Vlasenko
2008-04-11
Subject
build system: use POSIX options only for cp cp: improve comment
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
Makefile.custom+3 -2
| @@ -47,10 +47,11 @@ ifneq ($(strip $(DO_INSTALL_LIBS)),n) | |
| endif | |
| # Not very elegant: copies testsuite to objdir... | |
| + | # (cp -pPR is POSIX-compliant (cp -dpR or cp -a would not be)) |
| .PHONY: check | |
| .PHONY: test | |
| check test: busybox busybox.links | |
| - | test -d $(objtree)/testsuite || cp -a $(srctree)/testsuite $(objtree) |
| + | test -d $(objtree)/testsuite || cp -pPR $(srctree)/testsuite $(objtree) |
| bindir=$(objtree) srcdir=$(srctree)/testsuite \ | |
| $(SHELL) -c "cd $(objtree)/testsuite && $(srctree)/testsuite/runtest $(if $(KBUILD_VERBOSE:0=),-v)" | |
| @@ -58,7 +59,7 @@ check test: busybox busybox.links | |
| release: distclean | |
| cd ..; \ | |
| rm -r -f busybox-$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION); \ | |
| - | cp -a busybox busybox-$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION) && { \ |
| + | cp -pPR busybox busybox-$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION) && { \ |
| find busybox-$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION)/ -type d \ | |
| -name .svn \ | |
| -print \ | |
coreutils/cp.c+1 -1
| @@ -44,7 +44,7 @@ int cp_main(int argc, char **argv) | |
| // Soft- and hardlinking don't mix | |
| // -P and -d are the same (-P is POSIX, -d is GNU) | |
| // -r and -R are the same | |
| - | // -R (and therefore -r) switches on -d (coreutils does this) |
| + | // -R (and therefore -r) turns on -d (coreutils does this) |
| // -a = -pdR | |
| opt_complementary = "-2:l--s:s--l:Pd:rRd:Rd:apdR"; | |
| flags = getopt32(argv, FILEUTILS_CP_OPTSTR "arPHL"); | |