82327f4be

Rob Landley

2005-12-11

SOURCE BUG Duration: 7s

Subject

Patch from Yann E. Morin to make rmmod report failure properly.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

modutils/rmmod.c +2 -2

modutils/rmmod.c+2 -2

@@ -78,7 +78,7 @@ extern int rmmod_main(int argc, char **argv)
	size_t pnmod = -1; /* previous number of modules */

	while (nmod != pnmod) {
-	if (syscall(__NR_delete_module, NULL, flags) < 0) {
+	if (syscall(__NR_delete_module, NULL, flags) != 0) {
	if (errno==EFAULT)
	return(ret);
	bb_perror_msg_and_die("rmmod");
@@ -112,7 +112,7 @@ extern int rmmod_main(int argc, char **argv)
	#else
	#define module_name argv[n]
	#endif
-	if (syscall(__NR_delete_module, module_name, flags) < 0) {
+	if (syscall(__NR_delete_module, module_name, flags) != 0) {
	bb_perror_msg("%s", argv[n]);
	ret = EXIT_FAILURE;
	}