← Commit list

834aba3b7

Denys Vlasenko
Denys Vlasenko
2016-11-04
SUCCESS Duration: 188s

Subject

comment and readme updates

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

libbb/common_bufsiz.c+9 -0
@@ -54,6 +54,15 @@ char bb_common_bufsiz1[COMMON_BUFSIZE] ALIGNED(sizeof(long long));
#else
# ifndef setup_common_bufsiz
+/* For now, this is never used:
+ * scripts/generate_BUFSIZ.sh never generates "malloced" bufsiz1:
+ * enum { COMMON_BUFSIZE = 1024 };
+ * extern char *const bb_common_bufsiz1;
+ * void setup_common_bufsiz(void);
+ * This has proved to be worse than the approach of defining
+ * larger bb_common_bufsiz1[] array.
+ */
+
/*
* It is not defined as a dummy macro.
* It means we have to provide this function.
loginutils/README+1 -1
@@ -23,7 +23,7 @@ Getty should establish a new session and process group, and ensure
that tty is a ctty.
??? Should getty ensure that other processes which might have opened
-fds to this tty be dusconnected? agetty has a -R option which makes
+fds to this tty be disconnected? agetty has a -R option which makes
agetty call vhangup() after tty is opened. (Then agetty opens it again,
since it probably vhangup'ed its own fd too).