85f9e32f7

Denis Vlasenko

2006-09-19

SOURCE BUG Duration: 54s

Subject

mount: fstabname needs to be const char*

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

util-linux/mount.c +3 -2

util-linux/mount.c+3 -2

@@ -1432,7 +1432,8 @@ int mount_main(int argc, char **argv)
	enum { OPT_ALL = 0x8 };

	char cmdopts = xstrdup(""), fstype=0, *storage_path=0;
-	char opt_o, fstabname;
+	char *opt_o;
+	const char *fstabname;
	FILE *fstab;
	int i, j, rc = 0;
	unsigned long opt;
@@ -1526,7 +1527,7 @@ int mount_main(int argc, char **argv)

	fstab = setmntent(fstabname,"r");
	if (!fstab)
-	bb_perror_msg_and_die("cannot read %s",fstabname);
+	bb_perror_msg_and_die("cannot read %s", fstabname);

	// Loop through entries until we find what we're looking for.