863073da0

Bernhard Reutner-Fischer

2006-06-04

SOURCE BUG Duration: 39s

Subject

- add note about removing superfluous fmt specifiers

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

TODO +7 -2

TODO+7 -2

@@ -259,12 +259,17 @@ Minor stuff:
	if(!ioctl (fd, WDIOC_GETTIMEOUT, &tmo)) timer_duration = 1 + (tmo / 2);
	Unfortunately, that needs linux/watchdog.h and that contains unfiltered
	kernel types on some distros, which breaks the build.
-
+	---
	use bb_error_msg where appropriate: See
	egrep "(printf.\([[:space:]](stderr\|2)\|[^_]write.\([[:space:]](stderr\|2))"
-
+	---
	use bb_perror_msg where appropriate: See
	egrep "[^_]perror"
+	---
+	Remove superfluous fmt occurances: e.g.
+	fprintf(stderr, "%s: %s not found\n", "unalias", *argptr);
+	-> fprintf(stderr, "unalias: %s not found\n", *argptr);
+	---


	Code cleanup: