88663e481
Denys Vlasenko
2018-01-14
Subject
mv: make it NOEXEC
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
NOFORK_NOEXEC.lst+2 -2
| @@ -89,7 +89,7 @@ clear - NOFORK | |
| cmp - runner | |
| comm - runner | |
| conspy - interactive, longterm | |
| - | cp - noexec. runner |
| + | cp - noexec. sometimes runner |
| cpio - runner | |
| crond - daemon | |
| crontab - longterm (runs $EDITOR), leaks: open+xasprintf | |
| @@ -255,7 +255,7 @@ mount - suid | |
| mountpoint - noexec. leaks: option -n "print dev name": find_block_device -> readdir+xstrdup | |
| mpstat - longterm: "mpstat 1" runs indefinitely | |
| mt - hardware | |
| - | mv - noexec candidate, runner |
| + | mv - noexec. sometimes runner |
| nameif - noexec. openlog(), leaks: config_open2+ioctl_or_perror_and_die | |
| nbd-client - noexec | |
| nc - runner | |
coreutils/cp.c+1 -0
| @@ -26,6 +26,7 @@ | |
| //config: Also add support for --parents option. | |
| //applet:IF_CP(APPLET_NOEXEC(cp, cp, BB_DIR_BIN, BB_SUID_DROP, cp)) | |
| + | /* NOEXEC despite cases when it can be a "runner" (cp -r LARGE_DIR NEW_DIR) */ |
| //kbuild:lib-$(CONFIG_CP) += cp.o | |
coreutils/mv.c+2 -1
| @@ -17,7 +17,8 @@ | |
| //config: help | |
| //config: mv is used to move or rename files or directories. | |
| - | //applet:IF_MV(APPLET(mv, BB_DIR_BIN, BB_SUID_DROP)) |
| + | //applet:IF_MV(APPLET_NOEXEC(mv, mv, BB_DIR_BIN, BB_SUID_DROP, mv)) |
| + | /* NOEXEC despite cases when it can be a "runner" (mv LARGE_DIR OTHER_FS) */ |
| //kbuild:lib-$(CONFIG_MV) += mv.o | |