← Commit list

88a2aa98e

Denis Vlasenko
Denis Vlasenko
2007-03-19
FAILED Duration: 12s

Subject

dpkg: free_package(NULL) is ok, so don't test for NULL, just free.

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

archival/dpkg.c+2 -5
@@ -643,8 +643,7 @@ static unsigned fill_package_struct(char *control_buffer)
return -1;
}
num = search_package_hashtable(new_node->name, new_node->version, VER_EQUAL);
- if (package_hashtable[num] != NULL)
- free_package(package_hashtable[num]);
+ free_package(package_hashtable[num]);
package_hashtable[num] = new_node;
return num;
}
@@ -1739,9 +1738,7 @@ int dpkg_main(int argc, char **argv)
}
for (i = 0; i < PACKAGE_HASH_PRIME; i++) {
- if (package_hashtable[i] != NULL) {
- free_package(package_hashtable[i]);
- }
+ free_package(package_hashtable[i]);
}
for (i = 0; i < STATUS_HASH_PRIME; i++) {