← Commit list

9092f754b

Denis Vlasenko
Denis Vlasenko
2008-06-26
FAILED Duration: 25s

Subject

print_flags: fix trivial thinko vi: fix reversed checks for underflow

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

editors/vi.c+2 -2
@@ -1659,12 +1659,12 @@ static char *char_insert(char *p, char c) // insert the char c at 'p'
cmdcnt = 0;
end_cmd_q(); // stop adding to q
last_status_cksum = 0; // force status update
- if ((p[-1] != '\n') && (dot > text)) {
+ if ((p > text) && (p[-1] != '\n')) {
p--;
}
} else if (c == erase_char || c == 8 || c == 127) { // Is this a BS
// 123456789
- if ((p[-1] != '\n') && (dot>text)) {
+ if ((p > text) && (p[-1] != '\n')) {
p--;
p = text_hole_delete(p, p); // shrink buffer 1 char
}
libbb/print_flags.c+1 -1
@@ -19,8 +19,8 @@ int print_flags_separated(const int *masks, const char *labels, int flags, const
labels);
need_separator = separator;
flags &= ~ *masks;
- masks++;
}
+ masks++;
labels += strlen(labels) + 1;
}
return flags;