← Commit list

90e9cfd21

Denys Vlasenko
Denys Vlasenko
2013-08-20
SUCCESS Duration: 200s

Subject

dd: remove FIXME comment which is fixed now. No code changes

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

coreutils/dd.c+1 -4
@@ -403,12 +403,9 @@ int dd_main(int argc UNUSED_PARAM, char **argv)
(unsigned long)prev_read_size);
prev_read_size = n;
- /*
- * If n is odd, last byte is not swapped:
+ /* If n is odd, last byte is not swapped:
* echo -n "qwe" | dd conv=swab
* prints "wqe".
- * The code does not handle correctly odd-sized reads
- * in the *middle* of the input. FIXME.
*/
p16 = (void*) ibuf;
end = (void*) (ibuf + (n & ~(ssize_t)1));