919c10dd8
Denis Vlasenko
2007-01-03
Subject
ping[6]: don't do htons(a++), it can be a macro
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
networking/ping.c+2 -1
| @@ -218,9 +218,10 @@ static void sendping(int junk) | |
| pkt->icmp_type = ICMP_ECHO; | |
| pkt->icmp_code = 0; | |
| pkt->icmp_cksum = 0; | |
| - | pkt->icmp_seq = htons(ntransmitted++); |
| + | pkt->icmp_seq = htons(ntransmitted); /* don't ++ here, it can be a macro */ |
| pkt->icmp_id = myid; | |
| CLR(ntohs(pkt->icmp_seq) % MAX_DUP_CHK); | |
| + | ntransmitted++; |
| gettimeofday((struct timeval *) &pkt->icmp_dun, NULL); | |
| pkt->icmp_cksum = in_cksum((unsigned short *) pkt, sizeof(packet)); | |
networking/ping6.c+2 -1
| @@ -206,9 +206,10 @@ static void sendping(int junk) | |
| pkt->icmp6_type = ICMP6_ECHO_REQUEST; | |
| pkt->icmp6_code = 0; | |
| pkt->icmp6_cksum = 0; | |
| - | pkt->icmp6_seq = htons(ntransmitted++); |
| + | pkt->icmp6_seq = htons(ntransmitted); /* don't ++ here, it can be a macro */ |
| pkt->icmp6_id = myid; | |
| CLR(pkt->icmp6_seq % MAX_DUP_CHK); | |
| + | ntransmitted++; |
| gettimeofday((struct timeval *) &pkt->icmp6_data8[4], NULL); | |