← Commit list

91e006c1a

Russ Dill
Russ Dill
2004-05-19
FAILED Duration: 36s

Subject

remove uneccessary check (already done in pidfile.c)

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

networking/udhcp/common.c+4 -6
@@ -60,13 +60,13 @@ void background(const char *pidfile)
int pid_fd;
/* hold lock during fork. */
- if (pidfile) pid_fd = pidfile_acquire(pidfile);
+ pid_fd = pidfile_acquire(pidfile);
if (daemon(0, 0) == -1) {
perror("fork");
exit(1);
}
daemonized++;
- if (pidfile) pidfile_write_release(pid_fd);
+ pidfile_write_release(pid_fd);
#endif /* __uClinux__ */
}
@@ -96,10 +96,8 @@ void start_log_and_pid(const char *client_server, const char *pidfile)
sanitize_fds();
/* do some other misc startup stuff while we are here to save bytes */
- if (pidfile) {
- pid_fd = pidfile_acquire(pidfile);
- pidfile_write_release(pid_fd);
- }
+ pid_fd = pidfile_acquire(pidfile);
+ pidfile_write_release(pid_fd);
/* equivelent of doing a fflush after every \n */
setlinebuf(stdout);