948a09d6f

Mike Frysinger

2006-03-23

SOURCE BUG Duration: 22s

Subject

dont printf arguments given by user for security sanity

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

coreutils/watch.c +1 -1 miscutils/mountpoint.c +1 -1 miscutils/setsid.c +1 -1 util-linux/fdformat.c +1 -1

coreutils/watch.c+1 -1

@@ -100,7 +100,7 @@ int watch_main(int argc, char **argv)
	//child
	dup2(old_stdout, STDOUT_FILENO);
	execvp(*watched_argv, watched_argv);
-	bb_perror_msg_and_die(*watched_argv);
+	bb_perror_msg_and_die("%s", *watched_argv);
	} else {
	bb_perror_msg_and_die("vfork");
	}

miscutils/mountpoint.c+1 -1

@@ -64,7 +64,7 @@ int mountpoint_main(int argc, char **argv)
	}
	}
	if (!(opt & OPT_q))
-	bb_perror_msg(arg);
+	bb_perror_msg("%s", arg);
	return EXIT_FAILURE;
	}
	}

miscutils/setsid.c+1 -1

@@ -41,6 +41,6 @@ setsid_main(int argc, char *argv[]) {

	execvp(argv[1], argv + 1);

-	bb_perror_msg_and_die(argv[1]);
+	bb_perror_msg_and_die("%s", argv[1]);

	}

util-linux/fdformat.c+1 -1

@@ -85,7 +85,7 @@ int fdformat_main(int argc,char **argv)

	/* R_OK is needed for verifying */
	if (stat(argv,&st) < 0 \|\| access(argv,W_OK \| R_OK ) < 0) {
-	bb_perror_msg_and_die(*argv);
+	bb_perror_msg_and_die("%s",*argv);
	}
	if (!S_ISBLK(st.st_mode)) {
	bb_error_msg_and_die("%s: not a block device",*argv);