95a040fac

Bernhard Reutner-Fischer

2006-05-27

SOURCE BUG Duration: 33s

Subject

- use the defines CURRENT_TTY and VC_1; also shrink xargs a tiny bit: add/remove: 0/0 grow/shrink: 2/6 up/down: 5/-37 (-32) function old new delta static.add_interface 271 274 +3 static.glob3

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

console-tools/setlogcons.c +1 -1 findutils/xargs.c +1 -3 miscutils/rx.c +1 -1

console-tools/setlogcons.c+1 -1

@@ -27,7 +27,7 @@ extern int setlogcons_main(int argc, char **argv)
	if (argc == 2)
	arg.subarg = atoi(argv[1]);

-	if (ioctl(bb_xopen("/dev/tty1", O_RDONLY), TIOCLINUX, &arg))
+	if (ioctl(bb_xopen(VC_1, O_RDONLY), TIOCLINUX, &arg))
	bb_perror_msg_and_die("TIOCLINUX");;

	return 0;

findutils/xargs.c+1 -3

@@ -311,9 +311,7 @@ static int xargs_ask_confirmation(void)
	int c, savec;

	if (!tty_stream) {
-	tty_stream = fopen("/dev/tty", "r");
-	if (!tty_stream)
-	bb_perror_msg_and_die("/dev/tty");
+	tty_stream = bb_xfopen(CURRENT_TTY, "r");
	/* pranoidal security by vodz */
	fcntl(fileno(tty_stream), F_SETFD, FD_CLOEXEC);
	}

miscutils/rx.c+1 -1

@@ -290,7 +290,7 @@ int rx_main(int argc, char **argv)
	bb_show_usage();

	fn = argv[1];
-	ttyfd = bb_xopen3("/dev/tty", O_RDWR, 0);
+	ttyfd = bb_xopen3(CURRENT_TTY, O_RDWR, 0);
	filefd = bb_xopen3(fn, O_RDWR\|O_CREAT\|O_TRUNC, 0666);

	if (tcgetattr(ttyfd, &tty) < 0)