← Commit list

99125c049

Denys Vlasenko
Denys Vlasenko
2017-08-05
SUCCESS Duration: 143s

Subject

chattr,lsattr,tune2fs: make them NOEXEC

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

NOFORK_NOEXEC.lst+3 -3
@@ -61,7 +61,7 @@ bzip2 - runner
cal - runner: cal -n9999
cat - runner
chat - needs ^C to work
-chattr - runner
+chattr - noexec. runner
chgrp - noexec. runner
chmod - noexec. runner
chown - noexec. runner
@@ -204,7 +204,7 @@ lpd - daemon
lpq - runner
lpr - runner
ls - noexec. runner
-lsattr - runner. noexec candidate (ls is, why not this one?)
+lsattr - noexec. runner
lsmod - noexec
lsof - complex
lspci - noexec candidate, too rare to bother for nofork
@@ -366,7 +366,7 @@ truncate - NOFORK
tty - NOFORK
ttysize - NOFORK
tunctl
-tune2fs - leaks: open+xfunc
+tune2fs - noexec. leaks: open+xfunc
ubiattach
ubidetach
ubimkvol
e2fsprogs/chattr.c+1 -1
@@ -15,7 +15,7 @@
//config: help
//config: chattr changes the file attributes on a second extended file system.
-//applet:IF_CHATTR(APPLET(chattr, BB_DIR_BIN, BB_SUID_DROP))
+//applet:IF_CHATTR(APPLET_NOEXEC(chattr, chattr, BB_DIR_BIN, BB_SUID_DROP, chattr))
//kbuild:lib-$(CONFIG_CHATTR) += chattr.o e2fs_lib.o
e2fsprogs/lsattr.c+2 -1
@@ -16,7 +16,8 @@
//config: help
//config: lsattr lists the file attributes on a second extended file system.
-//applet:IF_LSATTR(APPLET(lsattr, BB_DIR_BIN, BB_SUID_DROP))
+//applet:IF_LSATTR(APPLET_NOEXEC(lsattr, lsattr, BB_DIR_BIN, BB_SUID_DROP, lsattr))
+/* ls is NOEXEC, so we should be too! ;) */
//kbuild:lib-$(CONFIG_LSATTR) += lsattr.o e2fs_lib.o
e2fsprogs/tune2fs.c+1 -1
@@ -13,7 +13,7 @@
//config: tune2fs allows the system administrator to adjust various tunable
//config: filesystem parameters on Linux ext2/ext3 filesystems.
-//applet:IF_TUNE2FS(APPLET(tune2fs, BB_DIR_SBIN, BB_SUID_DROP))
+//applet:IF_TUNE2FS(APPLET_NOEXEC(tune2fs, tune2fs, BB_DIR_SBIN, BB_SUID_DROP, tune2fs))
//TODO alias to "tune2fs -L LABEL": //applet:IF_E2LABEL(APPLET_ODDNAME(e2label, tune2fs, BB_DIR_SBIN, BB_SUID_DROP, e2label))