9b6e03fd0

Denys Vlasenko

2025-07-06

SOURCE BUG Duration: 113s

Subject

libbb/yescrypt: remove unused yescrypt_region_t tmp

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): libbb/yescrypt eklenirken (2025-07-06 - 2025-07-07 arasi) once unutulan kaynak dosyalari (pw_encrypt_yes.c, hash_sha256_block.c, pw_ascii64.c), ardindan 64-bit'te derlenmeyen bir 'buflen' degiskeni (alg-yescrypt-kdf.c) vardi - busybox'in kendi kodundaki gercek hatalar (e5d3a8763 ile duzeltildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

libbb/yescrypt/alg-yescrypt-kdf.c +0 -7

libbb/yescrypt/alg-yescrypt-kdf.c+0 -7

@@ -806,7 +806,6 @@ static int yescrypt_kdf_body(
	uint64_t NROM,
	uint8_t *buf, size_t buflen)
	{
-	yescrypt_region_t tmp;
	const salsa20_blk_t *VROM;
	size_t B_size, V_size, XY_size, need;
	uint8_t B, S;
@@ -884,7 +883,6 @@ static int yescrypt_kdf_body(
	if (need < S_size)
	goto out_EINVAL;
	}
-	init_region(&tmp);
	if (local->aligned_size < need) {
	if (free_region(local))
	return -1;
@@ -956,11 +954,6 @@ static int yescrypt_kdf_body(
	explicit_bzero(dk, sizeof(dk));
	}

-	if (free_region(&tmp)) {
-	explicit_bzero(buf, buflen); /* must preserve errno */
-	return -1;
-	}
-
	/* Success! */
	return 0;