← Commit list

9de9c871b

Denys Vlasenko
Denys Vlasenko
2017-07-09
SUCCESS Duration: 144s

Subject

shuf: fix random line selection. Closes 9971

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

coreutils/shuf.c+1 -1
@@ -53,7 +53,7 @@ static void shuffle_lines(char **lines, unsigned numlines)
/* RAND_MAX can be as small as 32767 */
if (i > RAND_MAX)
r ^= rand() << 15;
- r %= i;
+ r %= i + 1;
tmp = lines[i];
lines[i] = lines[r];
lines[r] = tmp;