9e4100bf9

Rob Landley

2006-01-10

SOURCE BUG Duration: 9s

Subject

Don't return 0 when there's an error.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

archival/libunarchive/decompress_unzip.c +2 -0

archival/libunarchive/decompress_unzip.c+2 -0

@@ -973,6 +973,7 @@ extern int inflate_gunzip(int in, int out)
	/* Validate decompression - crc */
	if (stored_crc != (gunzip_crc ^ 0xffffffffL)) {
	bb_error_msg("crc error");
+	return -1;
	}

	/* Validate decompression - size */
@@ -980,6 +981,7 @@ extern int inflate_gunzip(int in, int out)
	(bytebuffer[bytebuffer_offset] \| (bytebuffer[bytebuffer_offset+1] << 8) \|
	(bytebuffer[bytebuffer_offset+2] << 16) \| (bytebuffer[bytebuffer_offset+3] << 24))) {
	bb_error_msg("Incorrect length");
+	return -1;
	}

	return 0;