← Commit list

9fd61be19

Denys Vlasenko
Denys Vlasenko
2016-09-05
SUCCESS Duration: 204s

Subject

libbb/xwrite: print errno on "short write" errors

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

libbb/xfuncs_printf.c+10 -2
@@ -235,8 +235,16 @@ void FAST_FUNC xwrite(int fd, const void *buf, size_t count)
{
if (count) {
ssize_t size = full_write(fd, buf, count);
- if ((size_t)size != count)
- bb_error_msg_and_die("short write");
+ if ((size_t)size != count) {
+ /*
+ * Two cases: write error immediately;
+ * or some writes succeeded, then we hit an error.
+ * In either case, errno is set.
+ */
+ bb_perror_msg_and_die(
+ size >= 0 ? "short write" : "write error"
+ );
+ }
}
}
void FAST_FUNC xwrite_str(int fd, const char *str)