a299efb7b

Rob Landley

2006-08-10

SOURCE BUG Duration: 29s

Subject

Make a warning go away when standalone shell is disabled.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

shell/msh.c +8 -9

shell/msh.c+8 -9

@@ -3126,18 +3126,17 @@ static char rexecve(char c, char v, char envp)
	int i;
	char sp, tp;
	int eacces = 0, asis = 0;
-
-	#ifdef CONFIG_FEATURE_SH_STANDALONE_SHELL
	char *name = c;

-	optind = 1;
-	if (find_applet_by_name(name)) {
-	/* We have to exec here since we vforked. Running
-	* run_applet_by_name() won't work and bad things
-	* will happen. */
-	execve(CONFIG_BUSYBOX_EXEC_PATH, v, envp);
+	if (ENABLE_FEATURE_SH_STANDALONE_SHELL) {
+	optind = 1;
+	if (find_applet_by_name(name)) {
+	/* We have to exec here since we vforked. Running
+	* run_applet_by_name() won't work and bad things
+	* will happen. */
+	execve(CONFIG_BUSYBOX_EXEC_PATH, v, envp);
+	}
	}
-	#endif

	DBGPRINTF(("REXECVE: c=%p, v=%p, envp=%p\n", c, v, envp));