a2eec6051
"Vladimir N. Oleynik"
2005-10-15
Subject
RESERVE_CONFIG_BUFFER --> bb_common_bufsiz1
SOURCE BUG
This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
coreutils/date.c+2 -4
| @@ -282,10 +282,8 @@ int date_main(int argc, char **argv) | |
| { | |
| /* Print OUTPUT (after ALL that!) */ | |
| - | RESERVE_CONFIG_BUFFER(t_buff, 201); |
| - | strftime(t_buff, 200, date_fmt, &tm_time); |
| - | puts(t_buff); |
| - | RELEASE_CONFIG_BUFFER(t_buff); |
| + | strftime(bb_common_bufsiz1, 200, date_fmt, &tm_time); |
| + | puts(bb_common_bufsiz1); |
| } | |
| return EXIT_SUCCESS; | |
coreutils/realpath.c+7 -1
| @@ -30,7 +30,13 @@ int realpath_main(int argc, char **argv) | |
| { | |
| int retval = EXIT_SUCCESS; | |
| + | #if PATH_MAX > (BUFSIZ+1) |
| RESERVE_CONFIG_BUFFER(resolved_path, PATH_MAX); | |
| + | # define resolved_path_MUST_FREE 1 |
| + | #else |
| + | #define resolved_path bb_common_bufsiz1 |
| + | # define resolved_path_MUST_FREE 0 |
| + | #endif |
| if (--argc == 0) { | |
| bb_show_usage(); | |
| @@ -46,7 +52,7 @@ int realpath_main(int argc, char **argv) | |
| } | |
| } while (--argc); | |
| - | #ifdef CONFIG_FEATURE_CLEAN_UP |
| + | #if ENABLE_FEATURE_CLEAN_UP && resolved_path_MUST_FREE |
| RELEASE_CONFIG_BUFFER(resolved_path); | |
| #endif | |
procps/pidof.c+1 -3
| @@ -60,7 +60,7 @@ extern int pidof_main(int argc, char **argv) | |
| #if ENABLE_FEATURE_PIDOF_OMIT | |
| /* fill omit list. */ | |
| { | |
| - | RESERVE_CONFIG_BUFFER(getppid_str, 32); |
| + | char getppid_str[32]; |
| llist_t * omits_p = omits; | |
| while (omits_p) { | |
| /* are we asked to exclude the parent's process ID? */ | |
| @@ -76,8 +76,6 @@ extern int pidof_main(int argc, char **argv) | |
| } | |
| omits_p = omits_p->link; | |
| } | |
| - | if (ENABLE_FEATURE_CLEAN_UP) |
| - | RELEASE_CONFIG_BUFFER(getppid_str); |
| } | |
| #endif | |
| /* Looks like everything is set to go. */ | |