a62b0e745

"Vladimir N. Oleynik"

2005-12-06

SOURCE BUG Duration: 7s

Subject

reduce 3 warning if compile with -W

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

archival/tar.c +5 -2

archival/tar.c+5 -2

@@ -322,6 +322,8 @@ static inline int exclude_file(const llist_t excluded_files, const char file)

	return 0;
	}
+	# else
+	#define exclude_file(excluded_files, file) 0
	# endif

	static int writeFileToTarball(const char fileName, struct stat statbuf,
@@ -449,6 +451,7 @@ static inline int writeTarFile(const int tar_fd, const int verboseFlag,
	/* Avoid vfork clobbering */
	(void) &include;
	(void) &errorFlag;
+	(void) &zip_exec;
	# endif

	gzipPid = vfork();
@@ -463,7 +466,7 @@ static inline int writeTarFile(const int tar_fd, const int verboseFlag,
	close(gzipStatusPipe[0]);
	fcntl(gzipStatusPipe[1], F_SETFD, FD_CLOEXEC); /* close on exec shows sucess */

-	execlp(zip_exec, zip_exec, "-f", 0);
+	execlp(zip_exec, zip_exec, "-f", NULL);
	vfork_exec_errno = errno;

	close(gzipStatusPipe[1]);
@@ -479,7 +482,7 @@ static inline int writeTarFile(const int tar_fd, const int verboseFlag,

	if (n == 0 && vfork_exec_errno != 0) {
	errno = vfork_exec_errno;
-	bb_perror_msg_and_die("Could not exec %s",zip_exec);
+	bb_perror_msg_and_die("Could not exec %s", zip_exec);
	} else if ((n < 0) && (errno == EAGAIN \|\| errno == EINTR))
	continue; /* try it again */
	break;