a6e603721

Rob Landley

2006-06-28

SOURCE BUG Duration: 33s

Subject

Fix bug http://bugs.busybox.net/view.php?id=874 where hexdump -C got its spacing wrong.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

libbb/dump.c +3 -2

libbb/dump.c+3 -2

@@ -424,7 +424,7 @@ static unsigned char *get(void)

	static void bpad(PR * pr)
	{
-	register char p1, p2;
+	char p1, p2;

	/*
	* remove all conversion flags; '-' is the only one valid
@@ -433,7 +433,8 @@ static void bpad(PR * pr)
	pr->flags = F_BPAD;
	*pr->cchar = 's';
	for (p1 = pr->fmt; *p1 != '%'; ++p1);
-	for (p2 = ++p1; p1 && strchr(" -0+#", p1); ++p1);
+	for (p2 = ++p1; p1 && strchr(" -0+#", p1); ++p1)
+	if (pr->nospace) pr->nospace--;
	while ((p2++ = p1++) != 0);
	}