← Commit list

a7c065354

Denys Vlasenko
Denys Vlasenko
2020-10-31
SUCCESS Duration: 150s

Subject

shell: update comments on the status of [[ ]] compat

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

shell/ash.c+3 -3
@@ -209,15 +209,15 @@
* Status of [[ support:
* && and || work as they should
* = is glob match operator, not equality operator: STR = GLOB
- * (in GLOB, quoting is significant on char-by-char basis: a*cd"*")
* == same as =
- * add =~ regex match operator: STR =~ REGEX
+ * =~ is regex match operator: STR =~ REGEX
* TODO:
* singleword+noglob expansion:
* v='a b'; [[ $v = 'a b' ]]; echo 0:$?
* [[ /bin/n* ]]; echo 0:$?
* quoting needs to be considered (-f is an operator, "-f" and ""-f are not; etc)
- * ( ) < > should not have special meaning
+ * ( ) < > should not have special meaning (IOW: should not require quoting)
+ * in word = GLOB, quoting should be significant on char-by-char basis: a*cd"*"
*/
#define BASH_TEST2 (ENABLE_ASH_BASH_COMPAT * ENABLE_ASH_TEST)
#define BASH_SOURCE ENABLE_ASH_BASH_COMPAT
shell/hush.c+1 -2
@@ -63,7 +63,6 @@
* reserved words: function select
* advanced test: [[ ]]
* process substitution: <(list) and >(list)
- * =~: regex operator
* let EXPR [EXPR...]
* Each EXPR is an arithmetic expression (ARITHMETIC EVALUATION)
* If the last arg evaluates to 0, let returns 1; 0 otherwise.
@@ -85,11 +84,11 @@
* v='a b'; [[ $v = 'a b' ]]; echo 0:$?
* [[ /bin/n* ]]; echo 0:$?
* = is glob match operator, not equality operator: STR = GLOB
- * (in GLOB, quoting is significant on char-by-char basis: a*cd"*")
* == same as =
* =~ is regex match operator: STR =~ REGEX
* TODO:
* quoting needs to be considered (-f is an operator, "-f" and ""-f are not; etc)
+ * in word = GLOB, quoting should be significant on char-by-char basis: a*cd"*"
*/
//config:config HUSH
//config: bool "hush (68 kb)"