← Commit list

a894a4bed

Denys Vlasenko
Denys Vlasenko
2017-08-06
SUCCESS Duration: 142s

Subject

raidautorun: make it NOEXEC

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

NOFORK_NOEXEC.lst+2 -2
@@ -274,7 +274,7 @@ pscan - longterm
pstree - noexec
pwd - NOFORK
pwdx - NOFORK
-raidautorun
+raidautorun - noexec. very simple. leaks: open+xioctl
rdate - needs ^C (may talk to DNS servers, which may be down)
rdev - leaks: find_block_device -> readdir+xstrdup
readlink - NOFORK
@@ -294,7 +294,7 @@ route - needs ^C (may talk to DNS servers, which may be down)
rpm - runner
rpm2cpio - runner
rtcwake - longterm: puts system to sleep, optimizing this for speed is pointless
-run-parts
+run-parts - longterm
runlevel - noexec. can be nofork if "endutxent()" is called unconditionally, but too rare to bother?
runsv - daemon
runsvdir - daemon
miscutils/raidautorun.c+1 -1
@@ -15,7 +15,7 @@
//config: raidautorun tells the kernel md driver to
//config: search and start RAID arrays.
-//applet:IF_RAIDAUTORUN(APPLET(raidautorun, BB_DIR_SBIN, BB_SUID_DROP))
+//applet:IF_RAIDAUTORUN(APPLET_NOEXEC(raidautorun, raidautorun, BB_DIR_SBIN, BB_SUID_DROP, raidautorun))
//kbuild:lib-$(CONFIG_RAIDAUTORUN) += raidautorun.o