aa516a61b

Rob Landley

2006-07-06

SOURCE BUG Duration: 38s

Subject

Fix three embarassing thinkos in the new dmesg.c: 1) the c argument shouldn't have had a : after that, dunno how that got there. 2) the xgetlarg for level was using size 3) because xgetlarg's error message _SUCKS_ (it does a show_usage() rather than giving any specific info about the range that was

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

util-linux/dmesg.c +3 -3

util-linux/dmesg.c+3 -3

@@ -15,16 +15,16 @@
	int dmesg_main(int argc, char *argv[])
	{
	char size, level;
-	int flags = bb_getopt_ulflags(argc, argv, "c:s:n:", &size, &level);
+	int flags = bb_getopt_ulflags(argc, argv, "cs:n:", &size, &level);

	if (flags & 4) {
-	if(klogctl(8, NULL, bb_xgetlarg(size, 10, 0, 10)))
+	if(klogctl(8, NULL, bb_xgetlarg(level, 10, 0, 10)))
	bb_perror_msg_and_die("klogctl");
	} else {
	int len;
	char *buf;

-	len = (flags & 2) ? bb_xgetlarg(size, 10, 4096, INT_MAX) : 16384;
+	len = (flags & 2) ? bb_xgetlarg(size, 10, 2, INT_MAX) : 16384;
	buf = xmalloc(len);
	if (0 > (len = klogctl(3 + (flags & 1), buf, len)))
	bb_perror_msg_and_die("klogctl");